search

feder-observatory / stellarphot

Stellar aperture photometry
https://stellarphot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

Fix #384, in which the comparison viewer misbehaves #385

Closed mwcraig closed 1 month ago

mwcraig commented 1 month ago

Most of the effort here was in constructing a test case that actually checks for #384. The fix was pretty trivial.

mwcraig commented 1 month ago

(github is currently having issues with actions....)

JuanCab commented 1 month ago

I'll look this over on Sunday.

mwcraig commented 1 month ago

Closing/reopening to trigger tests

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.49%. Comparing base (4867a3b) to head (f31ec85). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #385 +/- ## ========================================== + Coverage 78.44% 78.49% +0.05% ========================================== Files 27 27 Lines 3758 3758 ========================================== + Hits 2948 2950 +2 + Misses 810 808 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwcraig commented 1 month ago

There were a couple of pieces to it. One was -set-object being called late another was that value, not selected, should be used with the file chooser because of a now fixed) bug in ipyautoui,