feder-observatory / stellarphot

Stellar aperture photometry
https://stellarphot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

Etiher the documentation or `PhotometryData` needs updating... #452

Open mwcraig opened 2 months ago

mwcraig commented 2 months ago

In the documentation we say this about photometry data in stellarphot:

Photometry objects always have these attributes, also available dictionary-style:

+ ``mag`` -- the calibrated magnitude; may be missing (e.g. your data prior to calibration)
+ ``mag_err`` -- error in ``mag``
+ ``inst_mag`` -- the instrumental magnitude; may be missing (e.g. catalog data)
+ ``inst_mag_err`` -- error int the ``inst_mag``
+ ``band`` -- the filter of the magnitude; required
+ ``BJD`` -- Barycentric Julian Date of the midpoint of the observation; may be missing/masked
+ ``RA2000`` -- right ascension in degrees, in the ICRS frame at epoch 2000
+ ``DEC2000`` -- declination in degrees in the ICRS frame at epoch 2000

We should either update PhotometryData to do this (which seems like a fine and simple route) or update the documentation. I'd lean towards having a coordinate object provided instead of separate RA and Dec, though. The coordinate object is much more useful.

@JuanCab -- accumulating issues to talk through 😬

JuanCab commented 2 months ago

I have no problem with using a coordinate object to hold the positions although maybe providing properties to access RA and Dec easily might be useful, I can't remember if I assumed access to these coordinates everywhere.

As for augmenting issues, I am available most afternoons next week, just let me know.