search

feder-observatory / stellarphot

Stellar aperture photometry
https://stellarphot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

Revive transforms #468

Closed mwcraig closed 1 month ago

mwcraig commented 1 month ago

This PR gets magnitude transforms working again with the same level of functionality they had in stellarphot 1. There are still several issues with how this is done, but the intent here is to simply have some working transform code, not to improve it yet.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (1c89681) to head (5260c1c). Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
stellarphot/utils/magnitude_transforms.py 3.44% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #468 +/- ## ========================================== - Coverage 80.53% 80.05% -0.49% ========================================== Files 31 31 Lines 3987 4011 +24 ========================================== Hits 3211 3211 - Misses 776 800 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwcraig commented 1 month ago

Merging even though the test coverage is technically down...the modified code was not covered by tests before and still isn't....