search

feder-observatory / stellarphot

Stellar aperture photometry
https://stellarphot.readthedocs.io
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

Change ID field in apass_dr9 catalog #476

Closed mwcraig closed 4 weeks ago

mwcraig commented 4 weeks ago

Looks like Vizier dropped the Vizier-generated ID for APASS entries. This uses the field number in stead, which is not unique to each star, but we generate our own unique ID anyway.

Going to YOLO this since it is blocking progress for some students working on AAVSO posters....

mwcraig commented 4 weeks ago

🤬 no idea why profile code broke. Tracking that down....

mwcraig commented 4 weeks ago

🤬 no idea why profile code broke. Tracking that down....

The release of photutils 2 broke our tests. See #477 opened to track this issue. Also #478 (still a draft) that would add a test against dev versions of photutils and add a cron job that runs weekly to do our tests.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.32%. Comparing base (6b267ce) to head (b9bf579). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #476 +/- ## ======================================= Coverage 80.32% 80.32% ======================================= Files 32 32 Lines 4067 4067 ======================================= Hits 3267 3267 Misses 800 800 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.