search

federecio / dropwizard-swagger

a Dropwizard bundle that serves Swagger UI static content and loads Swagger endpoints.
Other
130 stars 186 forks source link

Update README regarding dedicated host & port #25

Closed marcelstoer closed 9 years ago

marcelstoer commented 9 years ago

The README documents swaggerDropwizard.onRun(configuration, environment, "your_host_here", 4242); but this method does not exist (anymore?). There's only a method that accepts a String but not an int.

federecio commented 9 years ago

It's been added recently, take a look at:

https://github.com/federecio/dropwizard-swagger/blob/master/src/main/java/io/federecio/dropwizard/swagger/SwaggerDropwizard.java#L60

marcelstoer commented 9 years ago

Ok, I see...it's just a bit confusing if the README refers to code that hasn't been released yet. Thanks for releasing 0.5.2 a few hours ago even though Sonatype doesn't seem to have it released to Central yet.

marcelstoer commented 9 years ago

even though Sonatype doesn't seem to have it released to Central yet

You sure you promoted it from staging? It's still not on Central.

federecio commented 9 years ago

You are certainly right, I left the process half done. Now it's there:

https://oss.sonatype.org/content/repositories/releases/io/federecio/dropwizard-swagger/0.5.2/

federecio commented 9 years ago

I guess I've been too lazy, apologize