Small fixes to make install.sql run without errors and warnings on newer MariaDB versions

federico-razzoli / sql_games

Games implemented ad stored procedures, playable in MariaDB

5 stars 6 forks source link

Small fixes to make install.sql run without errors and warnings on newer MariaDB versions #3

Closed KarlLevik closed 1 year ago

KarlLevik commented 4 years ago

I tested this on MariaDB 10.4 and got a few errors and warnings:

$ mariadb < install.sql Note (Code 1008): Can't drop database 'anagram'; database doesn't exist ERROR 1126 (HY000) at line 21 in file: './bulls_cows/install.sql': Can't open shared library '/usr/lib64/mysql/plugin/ha_sequence.so' (errno: 2, cannot open shared object file: No such file or directory) Note (Code 1305): PROCEDURE hangman.install_game does not exist Warning (Code 1287): ' INTO FROM...' instead

I suspect the ha_sequence error is because the sequence engine is now (since 10.1) installed by default.

My commits attempt to remove these errors/warnings.

federico-razzoli commented 1 year ago

Thank you, @KarlLevik!

It's a feature request that addresses multiple minor problems, so I'd prefer to look into them separately.

You're right about SEQUENCE: it's a built-in engine and it cannot be uninstalled. I removed its installation.
I remove the deprecated version of SELECT ... INTO.
Nowadays I must have changed some of my opinions. Now I think that IF EXISTS and IF NOT EXISTS make no sense in a context like this. I'll remove them, and if a new version will be released, it will be a separate file that applies the necessary changes.

For now, I'm leaving this pull request open as a memo.

federico-razzoli commented 1 year ago

@KarlLevik After 2 years from your PR, yesterday I felt inspired and I fixed the problems you highlight, but in a different way. So I'm technically rejecting this PR, but actually it was a useful contribute. Thank you!