federico-terzi / espanso-hub

The official espanso package repository
https://hub.espanso.org/
MIT License
24 stars 2 forks source link

Package update - medical-docs #20

Closed wressl closed 4 years ago

wressl commented 4 years ago

Please update the medical-docs package to 0.1.1 The link is: https://github.com/wressl/medical-docs Thanks!

federico-terzi commented 4 years ago

Hey,

Sorry for the late reply, I've been super busy these days! I've updated the package, thank you for the contribution.

PS. I really got to say, this package surprised me in a good way. This is a very effective use case for espanso, even better than what I originally thought possible!

Cheers :)

smeech commented 10 months ago

This is a fascinating package - one I might well have used in my professional career had it been available before I retired! I did use AutoHotKey extensively, however.

I collaborate, in a minor way, at Espanso, and a user raised an issue about your package which I think I was able to answer. We did wonder, however, why you recommended amending users' default.yml to add your global variables, rather than putting them at the top of your package.yml?

With best wishes, and apologies for using this route to attempt to send a private message!

wressl commented 10 months ago

Hi Stephen,

Thanks for your interest in the package. I have to admit I haven't been working on it in a while.

I recommended amending the default.yml with the global variables because I thought this would be the place for user specific settings. I would expect every user would change the value of the globals to reflect their identity and local needs. There may be a better way to do this but this was the best I was aware of. I suppose a user could edit the package itself but further updates to the package would require merging the changes rather than simply replacing the package files.

Regards, Bill

On Thu, Dec 14, 2023 at 8:01 AM Stephen Meech @.***> wrote:

This is a fascinating package - one I might well have used in my professional career had it been available before I retired! I did use AutoHotKey extensively, however.

I collaborate, in a minor way, at Espanso https://github.com/espanso/espanso and a user raised an issue about your package which I think I was able to answer. We did wonder, however, why you recommended amending users' default.yml to add your global variables, rather than putting them at the top of your package.yml?

With best wishes, and apologies for using this route to attempt to send a private message.

— Reply to this email directly, view it on GitHub https://github.com/federico-terzi/espanso-hub/issues/20#issuecomment-1856011079, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOLL7UQQUMZ6EPCQMKTVGHDYJMIFFAVCNFSM4M5TSQFKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVGYYDCMJQG44Q . You are receiving this because you authored the thread.Message ID: @.***>

-- Bill Ressl @.***

smeech commented 10 months ago

but further updates to the package would require merging the changes

Good point - I hadn't thought of that. Given that it's no longer being developed, it probably makes sense to move the global variables to package.yml, as that was the issue I answered, and amend the Readme.md to reflect the need to preserve local edits between updates, either as a temporary record or by moving them to default.yml.

As your own version is somewhat ahead of the one on espanso/hub, is this a good opportunity to update it to a final version? If you don't want to be bothered, I'll have a go myself.

wressl commented 10 months ago

Hi Stephen,Certainly can be updated as you suggest.  I have been busy with other projects for some time.  Thanks,BillSent from my iPhoneOn Dec 15, 2023, at 4:27 AM, Stephen Meech @.***> wrote:

but further updates to the package would require merging the changes

Good point - I hadn't thought of that. Given that it's no longer being developed, it probably makes sense to move the global variables to package.yml, as that was the issue I answered, and amend the Readme.md to reflect the need to preserve local edits between updates. As your own version is somewhat ahead of the one on espanso/hub, is this a good opportunity to update it to a final version?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>