search

federicobond / solidity-parser-antlr

A Solidity parser for JS built on top of a robust ANTLR4 grammar
MIT License
155 stars 56 forks source link

Fix assembly assignments parsing #46

Open LogvinovLeon opened 5 years ago

LogvinovLeon commented 5 years ago

Solidity accepts both options. This parser fails on first one and only accepts the second one. I know it's minor nit, but would be still good to accept both.

screen shot 2019-02-20 at 2 48 14 pm
federicobond commented 5 years ago

Solidity accepts both options.

federicobond commented 5 years ago

@LogvinovLeon good catch! Is this documented behaviour? Or just an oversight on the part of the Solidity team? Is there any mention of this in the issues or docs for ethereum/solidity?

LogvinovLeon commented 5 years ago

@federicobond I don't think it's documented. And I think it's a mistake it supports it. Maybe this should be an issue on a solidity repo instead

federicobond commented 5 years ago

Yeah, let's open an issue in the Solidity repo and see if they are willing to tighten things up a bit. I don't think many users expect it to work that way.