federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.69k stars 1.1k forks source link

Incompatible API use in your codes. #462

Closed jay2013 closed 6 years ago

jay2013 commented 6 years ago

Hi, We notice that you use net.fortuna.ical4j as an external library. this library use API like "<org.apache.commons.logging.Log: void debug(java.lang.Object)>", "<org.apache.commons.logging.Log: void trace(java.lang.Object)>" that are already removed after SDK level 23. These API use are very likely to cause crash to your app because the minSDKVersion of your APP is 16.

There are exist reachable path from your code to these api. For example, the reachable path to the first API we mentioned above is: <it.feio.android.omninotes.receiver.AlarmReceiver: void onReceive(android.content.Context,android.content.Intent)> --><it.feio.android.omninotes.SnoozeActivity: void setNextRecurrentReminder(it.feio.android.omninotes.models.Note)> --><it.feio.android.omninotes.helpers.date.DateHelper: java.lang.Long nextReminderFromRecurrenceRule(long,java.lang.String)> --><it.feio.android.omninotes.helpers.date.DateHelper: java.lang.Long nextReminderFromRecurrenceRule(long,long,java.lang.String)> --><net.fortuna.ical4j.model.Recur: net.fortuna.ical4j.model.Date getNextDate(net.fortuna.ical4j.model.Date,net.fortuna.ical4j.model.Date)> --><net.fortuna.ical4j.model.Recur: net.fortuna.ical4j.model.DateList getCandidates(net.fortuna.ical4j.model.Date,net.fortuna.ical4j.model.parameter.Value)> --><org.apache.commons.logging.Log: void debug(java.lang.Object)>

We use android studio to analyze your app's apk file, and we also find methods in org.apache.commons.logging.Log don't have definition, they are all referenced methods which need android platform to support.

it feio android omninotes

more bugs, please refer to this file below. it.feio.android.omninotes.foss_238.apk .txt

We cannot make 100% sure about the reachable path, so we need your help to check whether it is reachable from your code to these unsupported API. Thanks very much.

best regards,

Dongjie He

jay2013 commented 6 years ago

Hi, Can you tell me how you fix these issues or if our reports are false positives? Thanks a lot!