search

federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.69k stars 1.11k forks source link

Tag renaming #765

Closed dvsdata closed 4 years ago

dvsdata commented 4 years ago

Would it be possible to allow bulk renaming of tags?

Cheers,

dvsdata commented 4 years ago

Ok, I found a way of doing this by applying a new tag to a selection of notes. But, in so doing, I lost all the other tags on the selected notes...

On version 6.0.5

federicoiosue commented 4 years ago

Digging further into this issue, thanks for reporting

federicoiosue commented 4 years ago

Hi there, I gave a look to the app's behavior. What currently happens is the following:

  1. You have more than one note with tags already existing associated
  2. You bulk select them and use the option to associate tags
  3. What you have here, differently than when you do the same thing from inside note editor, is that you don't have any pre-selected tag

So, the bulk notes tagging feature currently is something like "edit tags for selected notes starting from scratch". This could by not the better thing for your situation but it's ok if you want to have full control on tagging.

Another solution could be to preselect the union of the whole set of tags but this would also change the previously associated tags to any of the notes.

More, let's say that this works as an "add tag" feature, but what if I want to bulk remove?

federicoiosue commented 4 years ago

Otherwise (just a mockup to remind myself a possible approach)

dvsdata commented 4 years ago

The three-state checkboxes would be awesome... Keep up the good work!

federicoiosue commented 4 years ago

Unlucky has not been possible to follow the three-state checkboxes way due to the fact that the library used for dialogs doesn't support that and injecting that behavior into third party dependency would have been difficult to maintain in future versions.

So now the behavior is changed as into the hypothesis stated above, that seems more intuitive: ...preselect the union of the whole set of tags but this would also change the previously associated tags to any of the notes...