search

federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.67k stars 1.11k forks source link

Location Bug Fixed #778

Closed sachin-0102 closed 3 years ago

sachin-0102 commented 3 years ago

This should fix the issue of #764 as that setting was deprecated from api 28 and above, I've assigned the required fix

sachin-0102 commented 3 years ago

I didn't quite catch that, what exactly do you want me to do?

federicoiosue commented 3 years ago

I'll elaborate a little too be as much complete as possible with my answer, but basically what I've asked you for is exactly what is stated into the README, in the "Test your code contributions!" section.

This project is actually my very first Android code. So a lot of things are outdated (I try to keep the code updated with latest framework changes but it's not that much easy), many others are real spaghetti coding, for to my lack of experience at that time in clean coding. As you can see by looking at both project board on GitHub or Sonarqube the most of my latest work has been done to reduce code debt and improve testing coverage to make the app more stable and help other developers to work on ON.

That's why whenever I find some bugs or implement new features covering that code with tests is very important.

federicoiosue commented 3 years ago

I'll elaborate a little too be as much complete as possible with my answer, but basically what I've asked you for is exactly what is stated into the README, in the "Test your code contributions!" section.

This project is actually my very first Android code. So a lot of things are outdated (I try to keep the code updated with latest framework changes but it's not that much easy), many others are real spaghetti coding, for to my lack of experience at that time in clean coding. As you can see by looking at both project board on GitHub or Sonarqube the most of my latest work has been done to reduce code debt and improve testing coverage to make the app more stable and help other developers to work on ON.

That's why whenever I find some bugs or implement new features covering that code with tests is very important.

sachin-0102 commented 3 years ago

https://drive.google.com/file/d/1SwB_xf7Rv85u58uD5vetmYXgVW7oKaj9/view?usp=sharing

Please have a look at this video. I have also added a toast to tell the user what he's supposed to do.

sachin-0102 commented 3 years ago

Do Note ! I haven't changed anything in the last two files. I was trying to understand the code and I deleted a statement by mistake. I have undone it but its still showing that something's changed. So i've checked it. Everything's working fine