Removing tag removes special characters

federicoiosue / Omni-Notes

Open source note-taking application for Android

https://omninotes.app

GNU General Public License v3.0

2.68k stars 1.11k forks source link

Removing tag removes special characters #786

Closed WildOrangutan closed 3 years ago

WildOrangutan commented 3 years ago

Removing a tag from a note, can remove special characters like "new line", "comma", "minus", etc.

Reproduce: video

WildOrangutan commented 3 years ago

If you don't have any other plans, I would also like to fix this issue.

federicoiosue commented 3 years ago

Hi Peter,

thanks for reporting. Of course feel free to work on that but please pay attention to required contributions steps (code style, unit-test...) stated into the README!

WildOrangutan commented 3 years ago

Don't worry, will try my best to maintain code standards.

I have a minor question tough. I'm a bit confused with constant TAG_SPECIAL_CHARS_TO_REMOVE. Is that intended to determine where tags ends? For example, if content text is text (#tag) more text, parsed tag value should be #tag?