Main menu broken after removing Butterknife

federicoiosue / Omni-Notes

Open source note-taking application for Android

https://omninotes.app

GNU General Public License v3.0

2.68k stars 1.11k forks source link

Main menu broken after removing Butterknife #805

Closed tappdesign closed 3 years ago

tappdesign commented 3 years ago

Tap HarmburgerIcon - Main menu is not displayed anymore, after butterknife was removed. (Only categories are displayed). Something is wrong in MainMenuTask.java. When I reverted to older version, MainMenu is working again. It is hard to say what is wrong in current version of MainMenuTask.java.....

federicoiosue commented 3 years ago

Thanks for the feedback. Yes, I noticed it once I've installed the app on my device (I'm using the alpha as daily driver to check all the aspects still uncovered by the testing suite).

As you said is not that immediate to understand what's going wrong there due to binding class created by the framework itself. I have a couple of days with free time and I'm going to be back to work on that this evening.

federicoiosue commented 3 years ago

a1a77100f4980a2c175776fa9ad4eefad624c1cd temporarily fixed it. I've added an UI test to avoid further regression issues about this topic: 39a5a89ff58a6724c21cd2754a34a891f8da1d50