search

federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.69k stars 1.1k forks source link

Think about omitting settings file backup/restore #871

Closed federicoiosue closed 1 year ago

federicoiosue commented 1 year ago

Currently settings are exported to allow users to restore all their app's preferences on backup restore.

This currently causes two issues, in ascendent order of criticality:

  1. Storage Access Framework url in set right into settings, and would be overridden when restoring settings file
  2. There is no way to check correctness of a password trying to decode data on restoration, only if it's actually set or not. Importing settings would also override current password with the one from settings file itself, with still not much explorated side effects
andr222 commented 1 year ago

I agree that restoring settings could be problematic. I have a concern about importing/merging data so it does not replace/wipe out existing data. Would this work now, or is it intended to be added? Sorry if this is off topic, I thought it might be related.

federicoiosue commented 1 year ago

I agree that restoring settings could be problematic. I have a concern about importing/merging data so it does not replace/wipe out existing data. Would this work now, or is it intended to be added? Sorry if this is off topic, I thought it might be related.

Sorry for the late reply: if you're talking about merging/overriding data of notes themselves well, they are merged by design decisions; if you mean about settings' merge with currently existing ones I really think that removing they're restore could be a nice move.

A very recent change informs users to be sure to have password set before restoring protected notes, this should address the only real need of having settings restored with the whole backup.