federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.69k stars 1.1k forks source link

Screen rotation changes the colour of category. #890

Closed Burhan7777 closed 1 year ago

Burhan7777 commented 1 year ago

Whenever screen rotation happens the colour of the category changes.

Screen1 Screen2

shalenMathew commented 1 year ago

hey there is this issue closed

shalenMathew commented 1 year ago

??

federicoiosue commented 1 year ago

Hi there, it's not closed. I don't know if @Burhan7777 is still working on it

Burhan7777 commented 1 year ago

Currently not working on it but the issue exists and anyone can work on it.

shalenMathew commented 1 year ago

I am currently new to android, from what I observed that, the onCreate() gets recreated when the orientation is changed, so I saved the selectedColor value in the onSaveInstanceState method and restored it in the onCreate method using the savedInstanceState bundle, but its still not worjing can u guide me , what am I doing wrong?

Burhan7777 commented 1 year ago

Are you sure the selectedColor value is the color of the category ? Maybe category color value is assigned to some other variable. Please check what the selectedColor points to.

tgmiller5 commented 1 year ago

@shalenMathew I do not believe so. I tested this yesterday and the issue still appears.

federicoiosue commented 1 year ago

Updated build with fix will be available here shortly