Open unic77 opened 1 year ago
Awesome job, perfectly implemented!
I wrote to the old PR so you may have not read it but
I moved back the develop branch to SDK 31 (same with Jdk and Gradle tools). My fault, I forgot to add this breaking changes on a feature branch.
So please rebase your current feature branch on the current remote develop, this should also fix the currently failing github actions. Then I'll go with the merge!
i dont know how to rebase a git hub branch. do u maybe have some links with information
I'd to the following on your Git client:
The PR will be automatically updated I think
I think i fixed it. Thank you for the help.
I created an example PR: https://github.com/federicoiosue/Omni-Notes/pull/922
Please focus on the modified files: only the relevant ones are managed within the PR, they're 7 files. Instead this one hascurrently 16 files, most of the ones inherited from the old develop branch, the one before my rebase.
I still didn't tested the modification actually, so I suppose that it manages also images, as a minimum requirement. Am I correct?
Only the tekst is converted to the PDF file in this implementation. I would like to work further on this feature, if that is somthing that u are interested in. But at the moment my final exams in school are starting, so i wont be able to help. If its oke with u i would like to work on this feature further when my finalls are done.
also thank u for all the help.
No worries there is no ETA for any modification here.
I'll keep this PR open to let you have the time to fix the versioning tree (by compressing it to be like the one in https://github.com/federicoiosue/Omni-Notes/pull/922) and implement the other needed aspects of the pdf export.
Just to have a checklist, supposing the requirement to show the most of the relevant informations from the note itself:
A new item in the drop down menu (as shown in the pictures). When pressed, it wil create a PDF file that wil be stored in the documents folder of the user.
Test note:
Drop down menu:
Stored location:
Preview pdf fille: