search

federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.67k stars 1.11k forks source link

Bug Report: Search Filter does not apply #981

Closed XYIheng closed 3 weeks ago

XYIheng commented 1 month ago

Description:

The search filter doesn't apply to the note list if click the "Expanded view" or "Reduced view" button

Reproduce steps:

  1. search for a note
  2. click to enter the note
  3. back to the note list
  4. click more option on the right-up corner
  5. click "Reduced view" button
  6. see error: the filter text still exists, but the filter doesn't apply to the note list anymore.

Bug video:

https://github.com/federicoiosue/Omni-Notes/assets/31406320/4f2ca6d7-3d9a-435f-bdbb-7dce6596ab48

Environment:

Omninotes Version: 6.3.2 alpha, 6.2.8

DustinKong commented 1 month ago

Hi, I’m experiencing the same issue as described. Could the developers please look into this when possible? Thank you! Thank you for looking into this issue.

XYIheng commented 1 month ago

@federicoiosue hi, do you think this is an issue? If you agree, I can look into it and I think this should be easy to fix

DustinKong commented 1 month ago

@federicoiosue Hi! Certainly, I agree that while it might be an issue, it’s still worth addressing. If you could look into fixing it, that would be ideal. Thank you for bringing this to attention!

federicoiosue commented 3 weeks ago

@DustinKong solved successfully. Actually what I'd expect to be happening here is that the top toolbar should still be in "search mode" or, alternativelly, the search mode is deactivated when a node is entered. But this specific issue can be considered as solved.

DustinKong commented 3 weeks ago

@federicoiosue Hi~ Glad to see your further reply. The current situation is that in search mode, after reduced or enlarge the view, it is still in search mode and the node lists is still in a searched state. I'm a bit confused about the ideal state or function you're looking for. Can you describe it detailly? I can try to further improve the code.