search

federicoiosue / Omni-Notes

Open source note-taking application for Android
https://omninotes.app
GNU General Public License v3.0
2.69k stars 1.11k forks source link

Check for previous date set for reminder #991

Open pratistha-05 opened 1 month ago

pratistha-05 commented 1 month ago

When we set reminder, there is no check to not allow user to select past time or dates in date picker. Even after selecting wrong date, the reminder is set without any check to notify user to change the date. Possible solutions can be:

  1. Provide restriction to select previous date in date picker
  2. Show toast message to user to select appropriate dates
  3. show snackbar to let user know reminder cannot be set
eren8204 commented 2 weeks ago

@pratistha-05 can i start working on it

eren8204 commented 2 weeks ago

@federicoiosue hi i have added the functionality of preventing past reminder, can i make pull request now?

eren8204 commented 2 weeks ago

@pratistha-05 @federicoiosue add me as collaborator so that i can contribute

federicoiosue commented 2 weeks ago

@eren8204 you can open a pull request to be reviewed with no permission requirements on the project itself.

eren8204 commented 2 weeks ago

@federicoiosue i've raised the PR please look into that