federicomarini commented 2 years ago

Implementing the possibility to provide the gtl parameter at runtime, by uploading an RDS file where the gtl object is contained.

This should address a long-desired feature - and a quite useful one, to simplify the usage of GeneTonic in multiple contexts and contrasts.

Some additional tests might be required yet, and could still need some reworking in the happy_hour subset of functionality.

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (6849b32) into master (9ed4732) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #28    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           21        21            
  Lines         2565      2125   -440     
==========================================
- Hits          2565      2125   -440

Impacted Files	Coverage Δ
R/GeneTonic-extras.R	`100.00% <100.00%> (ø)`
R/GeneTonic.R	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ed4732...6849b32. Read the comment docs.

AnnekathrinSilvia commented 2 years ago

What could possibly be imporved:

In What is a GeneTonicList object in the Welcome panel:

[x] The first sentence is rather long, would probably be better to split that into two
[x] stoging -> storing
[x] everywhere else it is shaker_*here it's just shaker_, maybe we should make that consistent

In the Welcome panel tour:

[ ] the highlight of the sidebar in step 2 doesn't work
[ ] Step 12 is broken (the element with the text vanishes, you can't continue the tour)
[ ] Step 17 and 18 disappear at the right side of the monitor (you only see the outer border of the element), you can't continue the tour
[ ] there is no step explaning the upload box and upload functionality (I would suggest to put these before explaining the collabsible elements describing the individual inputs) and none explaining the GeneSpector element

Vignette:

[x] The text is a bit short on how to upload the gtl once GeneTonic runs (basically just a screenshot). I would probably add a sentence or two
[x] The Upload functionality is not mentioned in the ## The Welcome Panel section, but I think it should
[x] Last edited date should be changed (still 01.2020)

GeneTonic manpage:

[x] This should include an example how to start GeneTonic for the upload i.e. GeneTonic(size_gtl = 150)

federicomarini commented 2 years ago

I fixed the first three as they were straightforward, thanks!

As for the tour: this is some kind of issue with seems to be linked to bs4Dash - was not really there in the "classical" shinydashboard

federicomarini commented 2 years ago

Done these re: the vignette, thanks for catching up the gap in explanation!

federicomarini commented 2 years ago

For the tours: it is tricky to have the upload box in "in every case", as this is a widget which is not always there...

The GeneSpector can still be highlighted a little more, agreed. I'll see where I can place the anchors for it

federicomarini commented 2 years ago

Not sure I can really fix the placement of some of the elements... Otherwise: I think I addressed all elements of your feedback @AnnekathrinSilvia

Bumping the version up, and then it is ready to merge!

federicomarini / GeneTonic

Providing the GeneTonicList (gtl) at runtime #28

Codecov Report