Fixing immunedeconv difference V2

federicomarini / quantiseqr

https://federicomarini.github.io/quantiseqr/

GNU General Public License v3.0

0 stars 2 forks source link

Fixing immunedeconv difference V2 #21

Closed czackl closed 2 years ago

czackl commented 2 years ago

That should be it! I have been rerunning the test sript testing all parameter choices and the result match now the immunedecovn results.

If you like i can send you the test script and results on slack. @federicomarini @FFinotello

Have a great weekend! 🌞

federicomarini commented 2 years ago

Very very fine debugging job. Weird how the casting to data frame did lose somehow pieces of the relevant info 🤷 Thanks for putting this together. @FFinotello if you greenlight this one we can merge and update and push upstream and all the likes

czackl commented 2 years ago

How is the progress here? Should we merge it?

federicomarini commented 2 years ago

Sorry, I did sleep on this. Would make sense to do the regular version bumps and all for Bioc.

I'll be on it later and ping you 😉