Open Christian-Heyer opened 1 year ago
Hi Christian, @FFinotello has recently committed a change that could fix the behavior -> https://github.com/federicomarini/quantiseqr/commit/181ea43a0defae6a2e5dc13fa8abcd06980f45b5 Could you please double check the behavior is now correct?
I am also still having this exact same issue!
https://github.com/federicomarini/quantiseqr/blob/94e91fc190c8d876b15c0ae52199a5e7deb0f9ab/R/quantiseqr_helpers.R#L433
I am attempting to run quantiseq on the expression data from TCGA-STAD which I downloaded using TCGAbiolinks.
Before running I remove all duplicate gene names from the data matrix, however
mapGenes
introduces new duplicates in thenewgenes
vector however in in the line 433 of quantiseqr_helpers.R ofmapGenes
referenced above the original data matrix is checked for duplicate genes instead of the newgenes vector.I am not quite sure what
mapGenes
does and why it is introducing duplicate HGNC gene symbols when the original matrix has none,but changing it may make sense to check for duplicates in the newgenes vector instead of the original data matrix.Download TCGASTAD data: