search

federicopetronio / FLHET1D

1D fluid code for HET. This is the evolution of LPP1D.
0 stars 0 forks source link

Neutrals BC wrong at the anode #4

Open MartinGuillonLPP opened 2 weeks ago

MartinGuillonLPP commented 2 weeks ago

For all branches based on main

In FLHET_compiled.py, in

362 def SetInlet(...): ... 368 U_ghost[0] = (mdot - M P_In[1] P_In[2] / VG) / (A0 * VG)

is wrong to me because dimensionally not right. It should be:

368 U_ghost[0] = (mdot - M P_In[1] P_In[2] A0) / (A0 VG)

I don't think it is of great impact because the usual values we were using of $1/{VG}=0.005$ s/m and A0 $\approx 0.0044$ $m^2$ are close.

I already pushed a correction on main. I publish this issue for the devs of other branches who may be impacted.

federicopetronio commented 2 weeks ago

Correct, well noticed. Thanks.