search

federkasten / appbundle-maven-plugin

Maven plugin that creates an Application Bundle for OS X containing all your project dependencies and the necessary metadata
Apache License 2.0
180 stars 56 forks source link

Improved handling of iconFile #31

Closed nresare closed 8 years ago

nresare commented 8 years ago
  1. Lookup based on project.getBasedir() which makes it work as expected with multi module maven projects.
  2. Fail with an exception if iconFile is not found
nresare commented 8 years ago

Addresses the issues raised in https://github.com/federkasten/appbundle-maven-plugin/issues/30

federkasten commented 8 years ago

Thanks. I will review as soon as possible.

nresare commented 8 years ago

Thank you for having a look @federkasten

Revisiting my change I believe that just looking at files relative to project.getBasedir() in the first place does the expected thing with regards to both single module and multi module projects, and it makes the code more straightforward than my original proposal to first check the path relative to current working directory, then look at basedir after looking in target/classes.

nresare commented 8 years ago

Any progress on this? I would like to use it making a new release of https://github.com/nresare/javapasswordsafe and it seems neat to build release software using generally available tools.

federkasten commented 8 years ago

Merged. Sorry for the delay and thanks again.