Doesn't build the DMG on macOS 10.12.6

federkasten / appbundle-maven-plugin

Maven plugin that creates an Application Bundle for OS X containing all your project dependencies and the necessary metadata

Apache License 2.0

179 stars 56 forks source link

Doesn't build the DMG on macOS 10.12.6 #54

Closed Sami32 closed 6 years ago

Sami32 commented 6 years ago

This warning is displayed while building using Maven 3.3.9. It build fine under Linux OS. I suspect that it come from if (SystemUtils.IS_OS_MAC) { instead of being: if (SystemUtils.IS_OS_MAC_OSX || SystemUtils.IS_OS_MAC) {

mobreza commented 6 years ago

@Sami32 This is fixed in ef35749 and included in the 1.2.1-SNAPSHOT build.

Sami32 commented 6 years ago

Cool 👍 The 1.2.1-SNAPSHOT miss the metadata xml file to be downloaded from Maven.

federkasten commented 6 years ago

Fixed and deployed in1.2.1-SNAPSHOT. Sorry for the inconvenience.