search

fedi-e2ee / public-key-directory-specification

Specification for a Fediverse Directory Server for Public Keys
Other
42 stars 2 forks source link

PAE LE64() vs len() #38

Closed raphaelahrens closed 2 months ago

raphaelahrens commented 2 months ago

If there is no reason for using big endian for the len() function, would it not be better to reuse the LE64 function from pasetos PAE? Since it is already in use.

LE64 also is considering environments like the JVM where they have no unsigned ints.

https://github.com/fedi-e2ee/public-key-directory-specification/blob/c1e47e5da487e9f348a270e6fcb9de63dfad5055/Specification.md?plain=1#L1106-L1107

soatok commented 2 months ago

That's an excellent point. We should be consistent.

I have no personal preference on endian-ness, but if PASETO uses little-endian, we should probably just standardize on that.

soatok commented 2 months ago

39 should fix this discrepancy. Thanks @raphaelahrens