search

fedidcg / FedCM

A privacy preserving identity exchange Web API
https://fedidcg.github.io/FedCM
Other
357 stars 66 forks source link

Add a disconnect method #515

Closed npm1 closed 7 months ago

npm1 commented 7 months ago

Fixes https://github.com/fedidcg/FedCM/issues/496. Adds a disconnect_endpoint and a disconnect method to allow the RP to request the IDP to disconnect a previously connected federated account. I opted for disconnect_endpoint instead of disconnection_endpoint because it sounded a bit better to me, but open to change it. The credentialed request is sent with IDP cookies but using CORS as the request mode. If no account is found or there is some other error, the user agent removes all connections associated with the RP, IDP.

Preview | Diff

npm1 commented 7 months ago

Ping

yi-gu commented 7 months ago

lgtm

samuelgoto commented 7 months ago

LGTM

@bvandersloot-mozilla WDYT?

bvandersloot-mozilla commented 7 months ago

I think I follow and LGTM.

samuelgoto commented 7 months ago

I think I follow and LGTM.

Thanks @bvandersloot-mozilla ! @npm1 i'll wait for you to resolve the last remaining bits of feedback from @TallTed and then squash and merge.