Fix FedCM connection status computations

npm1 commented 7 months ago

In Chrome implementation, we actually have two different computations:

To allow auto reauthn, we need an account to actually be in the browser storage. Even if approved_clients says an account is returning, we need to have observed in the browser.
For the purpose of showing PP/TOS, we trust the IDP. If approved_clients is present, we rely on it. Otherwise, we rely on browser storage.

Note that the previous 'compute the connection status' algorithm now takes on the PP/TOS meaning, so its definition is slightly changed.

yi-gu commented 6 months ago

LGTM. Could you mention in the PR description that the term "connection" now has slightly different meaning?

npm1 commented 6 months ago

Done. Ben, this PR looks scary but the actual change is fairly small and summarized in the PR description. Let me know what you think

fedidcg / FedCM