search

fedidcg / LightweightFedCM

A Work Item of the Federated Identity Community Group.
9 stars 4 forks source link

Update explainer to reflect how IdentityCredentials are created by IdP in the demo page #35

Closed ekovac closed 1 month ago

ekovac commented 1 month ago

Currently the explainer examples for the IdP side use navigator.credentials.create() to instantiate a lightweight credential before storing; this doesn't align with the demonstration page or, presumably, the prototype implementation in Firefox Nightly. In that demonstration a new IdentityCredential is created using new. Is this the intention? Should both mechanisms for creating an IdentityCredential for storage be supported? Which would be more consistent with the Credential Management API family?

ekovac commented 1 month ago

The alternative of course is to update the demonstration page to match the explainer, but it's unclear which one is correct :)

bvandersloot-mozilla commented 1 month ago

Both should be supported IMO to be consistent with other Credential types, e.g. for PasswordCredential we have create and new.

ekovac commented 1 month ago

Closing this out; clarifying this probably doesn't need to be in the explainer.

bvandersloot-mozilla commented 1 month ago

:+1:, but it is good a good catch. Something like the webidl is maybe a little out of scope for the explainer but would resolve this confusion. I'll think about including it.

bvandersloot-mozilla commented 1 month ago

@ekovac : also, FYI: here is Firefox's webidl!