fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
568 stars 219 forks source link

Remove `expect` call from `gateway-cli` #1867

Closed justinmoon closed 1 year ago

justinmoon commented 1 year ago

Lots of expect call here. If the command failed, print message to STDERR. But don't panic.

elsirion commented 1 year ago

main already returns a Result:

https://github.com/fedimint/fedimint/blob/e5178267b58f184797c0fea2b004b83b8a12adbb/gateway/cli/src/main.rs#L66-L67

What happens if it's Err? If it does the right thin, we can just replace expect with ? everywhere. If not we might want a main_inner function and then do the logging in case of errors in main.

okjodom commented 1 year ago

Good first issue claimed offline by @nassersaazi . Please post any questions or progress updates in this thread

justinmoon commented 1 year ago

Closed by #1993