Closed gotlougit closed 1 year ago
Patch coverage has no change and project coverage change: -0.25
:warning:
Comparison is base (
4d95fb8
) 60.11% compared to head (5e836bc
) 59.86%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This works for me! Todo: remove all tmux references in repo
Nice!
LGTM, but Manmeet is the authority here. Feel free to ping me on Discord to ruberstamp after Manmeet approves. :)
Todo: remove all tmux references in repo
Let's do this in separate PR. Want to make sure this actually works for people before deleting tmuxinator.
Questions / comments:
$ just exit fed-shell
mprocs --ctl '{c: quit}'
Error: Server address is not defined.
fedimint-cli
isn't defined in the "user" window. I think you need to source this script like so.Makes sense. Then this PR is almost ready. I have added list of remaining tasks in PR description.
How should the user quit? I still can't figure that out.
currently it is:
exit
)When you quit, do all the processes get clean up?
Yes, but fedimintd takes a while.
fedimint-cli isn't defined in the "user" window.
added in remaining tasks
currently it is:
- close user shell manually. (
exit
)- Ctrl-A (focus out of terminal window) q (quit)
Nice, that worked for me.
I think we should copy scripts/tmux-user-shell.sh
to like scripts/mprocs-user-shell.sh
. Then we can source aliases.sh in it, as well as print out the instructions to quit.
Quitting now completely kills the bash shell, I tried using SIGINT
and SIGTERM
but they didn't seem to work, whereas brute force SIGKILL
did the job.
I have added tmuxinator back in as best I could, I think both mprocs and tmuxinator can co-exist for now
No problem, was happy to contribute!
Great work @gotlougit!
Fixes #2136, need some more polishing to get all the daemons running and some error handling like with the
tmuxinator.sh
script.Remaining tasks:
just exit-fed-shell
(start mprocs in server mode)