search

fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
579 stars 223 forks source link

Properly handle lagging broadcast channel in SM notifier #3557

Open elsirion opened 11 months ago

elsirion commented 11 months ago

We currently ignore the problem, probably getting some state machines stuck when it happens.

https://github.com/fedimint/fedimint/blob/c97add9a466a8ab4ad15c7854b75b96ace49d41b/fedimint-client/src/sm/notifier.rs#L180

justinmoon commented 11 months ago

Might this be relevant to https://github.com/fedimint/fedimint/issues/3478? I don't remember that error message, though ...

douglaz commented 11 months ago

Might this be relevant to #3478? I don't remember that error message, though ...

It seems #3478 happens in different scenarios and one of them is when this ModuleNotifier stream stopped error happens