Closed bradleystachurski closed 2 months ago
Attention: Patch coverage is 8.84956%
with 103 lines
in your changes are missing coverage. Please review.
Project coverage is 57.96%. Comparing base (
52f0c96
) to head (dba55b8
). Report is 174 commits behind head on master.:exclamation: Current head dba55b8 differs from pull request most recent head a5e00f8. Consider uploading reports for the commit a5e00f8 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
dev call: would be nice to merge flakiness offensive, then rebase this one it
Would be good if our devimint wizard @maan2003 could take a look before merging since I'm not as familiar with it :)
Thanks everyone for the reviews! I should be able to address/respond to all feedback in the next day or two. If this is approved/merged in the meantime, I'll make a followup PR.
Rebased and resolved merge conflicts, still need to address feedback 🙂
Dang, reached the 75 minute timeout in the merge queue for the 5x tests. Testing a timeout bump in a separate PR https://github.com/fedimint/fedimint/pull/4342
Dang, reached the 75 minute timeout in the merge queue for the 5x tests. Testing a timeout bump in a separate PR #4342
Wen parallel tests?
Wen parallel tests?
I don't think parallel back-compat would help for the 5x tests, but I think exploring this may help: https://github.com/fedimint/fedimint/pull/4247#discussion_r1496571057
Wen parallel tests?
I don't think parallel back-compat would help for the 5x tests, but I think exploring this may help: #4247 (comment)
Oh. OK. https://github.com/fedimint/fedimint/pull/4390
But also https://github.com/fedimint/fedimint/pull/4390
And then: Wen parallel tests, @bradleystachurski ? :D
Capturing an out-of-band chat with @dpc:
Rebased with the latency parallel improvements
This looks great to me. But I'm a little out-of-context so I'm going to defer "approval" to @dpc @elsirion and @maan2003.
Dangit, backend_test_bitcoind
is running much slower in CI than locally and timing out at 600s. Investigating...
Closes https://github.com/fedimint/fedimint/issues/4171
Inspired by https://github.com/fedimint/fedimint/pull/4173 and https://github.com/fedimint/fedimint/pull/4198
Introduces the ability to run rust and devimint tests with a parameterized number of peers offline, defaulting to a 3/4 setup.
Running all tests with a degraded federation increases the time for CI to finish by a material amount, so we should consider if running all tests degraded is worth the additional overhead.