Upgrade all (most) dependencies before releasing 0.3

fedimint / fedimint

Federated E-Cash Mint

https://fedimint.org/

MIT License

569 stars 221 forks source link

Upgrade all (most) dependencies before releasing 0.3 #4561

Open maan2003 opened 6 months ago

maan2003 commented 6 months ago

deps left:

[x] bech32
[x] bitcoin
[x] bitcoincore-rpc
[x] bitcoin_hashes
[x] bls12_381
[ ] cln-plugin
[x] electrum-client
[x] esplora-client
[x] ff
[ ] gloo-net
[x] group
[x] lightning
[x] lightning-invoice
[x] miniscript
[ ] rcgen
[x] secp256k1
[x] secp256k1-zkp
[ ] tokio-rustls

maan2003 commented 6 months ago

https://github.com/fedimint/fedimint/pull/4557 upgrade most of deps

justinmoon commented 6 months ago

Is this done?

maan2003 commented 6 months ago

nope, all deps listed are still not upgraded

elsirion commented 5 months ago

Unless there's a CVE being on the latest version isn't important for 0.3 imo. It's generally a good practice to avoid huge version jumps later on, but that can also happen on master later on. Only drawback is that any change to master will make backporting harder, but that's always the case no matter the change.

EDIT: the only thing that really needs bumping is rust-bitcoin imo and that should be a minor version bump: https://github.com/fedimint/fedimint/issues/4618

justinmoon commented 4 months ago

dev call: let's split the alephbft ones into separate issues. in order to update these, we need to execute a consensus upgrade. @tvolk131

tvolk131 commented 23 hours ago

Assigning to myself since I already did most of these and can wrap up the rest soon