search

fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
536 stars 209 forks source link

Define string constants for gateway endpoints #4819

Closed isaacknjama closed 1 week ago

isaacknjama commented 1 month ago

Addresses #4545

elsirion commented 1 month ago

Converted to draft while tests are failing. Please mark as ready for review once they are green and all comments have been addressed. You might also want to squash commits that only addresses comments before doing so.

m1sterc001guy commented 2 weeks ago

LGTM, running CI

m1sterc001guy commented 2 weeks ago

Lint is failing

m1sterc001guy commented 2 weeks ago

I think this needs a rebase to pickup some recent changes

dpc commented 2 weeks ago

Arrrgh. Rebase again. :(

Feel free to ping me on Discord to approve right away. And if I'm not there ask on #code-reviews channel.

m1sterc001guy commented 2 weeks ago

Can you try rebasing and then running the backwards compatibility tests locally? They're failing CI

dpc commented 2 weeks ago

Typo somewhere, that causes all previous versions not be able to communicate and back compat tests fail?

isaacknjama commented 1 week ago

Can you try rebasing and then running the backwards compatibility tests locally? They're failing CI

Running backward compatibility tests:

Command: CARGO_BUILD_JOBS=1 env TMPDIR=/tmp CARGO_PROFILE=ci nix develop -c nix shell github:rustshop/fs-dir-cache -c scripts/ci/run-in-fs-dir-cache.sh backward-compat env -u RUSTC_WRAPPER ./scripts/tests/test-ci-all-backcompat.sh v0.2.1 > backward-compatibility-tests.txt

Results: backward-compatibility-tests.txt

Search for '## FAIL' to find the end of the failing test

dpc commented 1 week ago

Commands will print stuff like --data-dir=/tmp/nix-shell.vapQS2/latency_test_ln_receive-IZa6/devimint-272590-882/. This is the dir that contains all the stuff like logs of all services. You can inspect logs/ of gateway-lnd andgateway-cln` and look for hints what is wrong.