search

fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
536 stars 209 forks source link

chore(deps): bump reqwest to 0.12.4 #4908

Open tvolk131 opened 1 month ago

tvolk131 commented 1 month ago

Bump everywhere except for fedimint-cli since it currently uses lnurl-rs v0.4.1 which uses reqwest v0.11 and causes an error here if we bump it, due to mismatching versions: https://github.com/fedimint/fedimint/blob/a3b9990ebcc5690f67b6a8e8895d8a9024bab77c/fedimint-cli/src/client.rs#L679

Once a new version of lnurl-rs is published that uses reqwest v0.12, we should be able to bump them both together for fedimint-cli without issue

Edit: a new version of lnurl-rs has been published and we're now bumping reqwest to v0.12.3 across the entire codebase along with bumping lnurl-rs from v0.4.1 to v0.5.0

elsirion commented 1 month ago

I opened https://github.com/benthecarman/lnurl-rs/pull/20 for reqwest.

tvolk131 commented 1 month ago

Looks like merge failed due to a timeout - anyone wanna put it back in the queue?

maan2003 commented 1 month ago

might be a real failure

elsirion commented 1 month ago

Apart from a possible real CI failure, we can also update lnurl-rs now and unify the reqwest dependency.

tvolk131 commented 1 month ago

might be a real failure

Apart from a possible real CI failure, we can also update lnurl-rs now and unify the reqwest dependency.

Rebased, updated lnurl-rs, and unified reqwest to v0.12.3 across the codebase! CI is passing again.

elsirion commented 4 weeks ago

I wasn't able to reproduce the CI failure in #5024, maybe we can just add the increased logging from that branch here so if it fails in the merge queue again we at least lern what that consensus item spam is about?

m1sterc001guy commented 3 weeks ago

Needs rebase but otherwise looks like it works

tvolk131 commented 3 weeks ago

Needs rebase but otherwise looks like it works

Rebased and CI is passing!