search

fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
530 stars 209 forks source link

Extract protobuf definition and generated code into separate crate #5057

Open m1sterc001guy opened 1 week ago

m1sterc001guy commented 1 week ago

We stuffed the protocol buffer definition into the Lightning Gateway crate and never moved it. Ideally this would be inside a lightweight crate by itself so only crates that need gRPC/protocol buffers depend on it. Currently anything that depends on ln-gateway, such as fedimint-testing needs to have protoc defined, which makes it hard for downstream crates to integrate fedimint-testing

justinmoon commented 4 days ago

dev call: we could check-in protobuf definitions, but need CI to check it and just command to update.

Could also switch away from protobuf towards JSON-RPC which is used elsewhere (should be separate issue). We have 3 kinds of APIs, and it would be nice to unify. LNv2 maybe be a good time to make this switch???