fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
536 stars 209 forks source link

feat: LNv2 Description Hashes and CLN Create Invoice #5160

Closed m1sterc001guy closed 2 weeks ago

m1sterc001guy commented 2 weeks ago

This PR is unfortunately difficult to test. That is because create_invoice is only used for LNv2 currently add there aren't currently tests that exercise paying into a Fedimint from an external Lightning node. Adding support for generating the invoice for LNv1 is a longer discussion, since we would need to figure out what backwards compatibility support we want (IMO we might want to do this in the future depending on when LNv2 ships). Adding testing support for paying fedimints from an external wallet using LNv2 requires adding CLI commands, which is out of scope for this PR.

Since this only affect LNv2 currently, I hope we can merge and iterate if any problems are found while we add tests. I think we need to overhaul and refactor a lot of the Lightning tests https://github.com/fedimint/fedimint/issues/5168