chore: Mock RPCs between Client -> Gateway

fedimint / fedimint

Federated E-Cash Mint

https://fedimint.org/

MIT License

536 stars 209 forks source link

chore: Mock RPCs between Client -> Gateway #5179

Closed m1sterc001guy closed 2 weeks ago

m1sterc001guy commented 2 weeks ago

Working towards: https://github.com/fedimint/fedimint/issues/5168

Gets rid of the ugly hack we used of removing the gateway's clients during the tests.

m1sterc001guy commented 2 weeks ago

@dpc fixes one of the sores of the lightning tests, next step is to convert the other tests to devimint tests and then rip out the real LN part

dpc commented 2 weeks ago

I think I've just seen a flake caused by the problem this fixes, so hitting the land button and adding the label to get more reviews later.

dpc commented 2 weeks ago

Unrelated flake we are already working on a fix in #5182

elsirion commented 2 weeks ago

Great work! We should strive to be able to mock out all network connection so that we can test state machines in module-local tests that don't need a whole devimint setup!