search

fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
536 stars 209 forks source link

fix(recoverytest): wait for next session before scanning session outcomes for pegins #5184

Closed elsirion closed 2 weeks ago

elsirion commented 2 weeks ago
bradleystachurski commented 2 weeks ago

For tracking MQ failure https://github.com/fedimint/fedimint/issues/5186

bradleystachurski commented 2 weeks ago

Oh shoot, the recoverytool failure showed up in the MQ

00:00:39 assertion failed: epochs_descriptors.contains(*utxo_descriptor)

https://github.com/fedimint/fedimint/actions/runs/8911963925/job/24474385524#step:5:925

dpc commented 2 weeks ago 
 00:00:36 2024-05-01T16:28:29.370540Z  INFO devimint::tests: Awaiting session outcome 2
00:00:36 2024-05-01T16:28:29.370598Z DEBUG fm::devimint: > fedimint-cli --data-dir=/tmp/nix-shell.jQkHEI/recoverytool_tests-BPu6/devimint-4154617-577/clients/recoverytool-test-client-0 dev api await_session_outcome 2
00:00:39 2024-05-01T16:28:32.566268Z  INFO devimint::tests: session found in 3.195712726s
00:00:39 2024-05-01T16:28:32.566290Z  INFO devimint::tests: Recovering using epochs method
00:00:39 2024-05-01T16:28:32.566335Z DEBUG fm::devimint: > recoverytool --readonly --cfg /tmp/nix-shell.jQkHEI/recoverytool_tests-BPu6/devimint-4154617-577/fedimintd-0 epochs --db /tmp/nix-shell.jQkHEI/recoverytool_tests-BPu6/devimint-4154617-577/fedimintd-0/database
00:00:39 thread 'main' panicked at /run/github-runner/runner-03-cc/fedimint/fedimint/devimint/src/tests.rs:2144:9:
00:00:39 assertion failed: epochs_descriptors.contains(*utxo_descriptor)
00:00:39 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
elsirion commented 2 weeks ago

Uff, now that's weird …

bradleystachurski commented 2 weeks ago

I'm still having trouble reproducing locally. Let's see if we can figure out more when it flakes again in CI https://github.com/fedimint/fedimint/pull/5192

edit: having trouble reproducing with the self-hosted runner now 😄

dpc commented 2 weeks ago

Maybe let's land and follow up if/when we spot it again?

elsirion commented 2 weeks ago

I'm ok with that, but not very satisfying :/

dpc commented 2 weeks ago 
 fedimint-test-all-wasm32-unknown-unknown-ci> 00:01:05 Error: Polling waiting-server-status: VerifyingConfigs failed after 109 retries (timeout: 60s)

That's new.

justinmoon commented 1 week ago

dev call: we thought this was a fix for https://github.com/fedimint/fedimint/issues/5182, but apparently not ...