search

fedimint / fedimint

Federated E-Cash Mint
https://fedimint.org/
MIT License
536 stars 209 forks source link

fix(server): panic when there are no peers #5189

Closed dpc closed 2 weeks ago

dpc commented 2 weeks ago
dpc commented 2 weeks ago

Should we also add here?

https://github.com/fedimint/fedimint/blob/5bd29c2d8c49cee33a5c3b9ff4bddcedb1d7eff4/fedimint-server/src/net/peers.rs#L343

Most certainly. @bradleystachurski . Done.

But ... why do we have such a copypasta here ... ?

bradleystachurski commented 2 weeks ago

But ... why do we have such a copypasta here ... ?

I was wondering the same thing, but was hoping you had context :smile:

dpc commented 2 weeks ago

I was wondering the same thing, but was hoping you had context 😄

I'm just the janitor, sir.

fedimint-backports commented 2 weeks ago

Successfully created backport PR for releases/v0.3:

elsirion commented 2 weeks ago

But ... why do we have such a copypasta here ... ?

AlephBFT didn't need reliable networking anymore, so @joschisan removed a lot of the related complexity. Then we noticed that setup/DKG still requires reliable networking and it got added back as a bug fix, probably not noticing that there was now a lot of duplication.

bradleystachurski commented 1 week ago

review club: requires more investigation to know if we can unify the different networking paths