search

fedimint / ui

https://ui-umber-ten.vercel.app
MIT License
26 stars 39 forks source link

feat: pass in query param for role #374

Closed Kodylow closed 6 months ago

Kodylow commented 6 months ago

Lets you pass in role as a query param so we can skip the first setup page, we've found it a hiccup when doing setups for fedi

okjodom commented 6 months ago

Lgtm. I'll test in a bit. PS, we can squash all commits into one

Kodylow commented 6 months ago

squashed

okjodom commented 6 months ago

@Kodylow when I was testing this, I found some bugs (tagged) but I actually took a step back wondering if we actually need to skip the first page because of query param. Might it be better to pre-select the role from the value of query param, but let the guardian click next to proceed?

Here is a cherry pick from validating the issue https://github.com/fedimint/ui/commit/9a9503d1f5aff859aabd1696110ab9eb9ac7f538

Kodylow commented 6 months ago

I agree that's better, then people acknowledge their role too. will update.

Kodylow commented 6 months ago

Updated, made it way simpler too just a single useeffect in RoleSelector.