feat: fix nix flake - Githubissues

justinmoon commented 6 months ago

This happens currently on mac:

$ nix develop
error: builder for '/nix/store/0f3p440vzing4xpdf9j37kq34z110hjz-bitcoind-26.0.drv' failed with exit code 2;
       last 10 log lines:
       > 4 errors generated.
       > 4 errors generated.
       > make[2]: *** [Makefile:11130: libbitcoin_node_a-txmempool.o] Error 1
       > make[2]: *** [Makefile:10864: libbitcoin_node_a-rest.o] Error 1
       > 4 errors generated.
       > make[2]: *** [Makefile:10234: libbitcoin_node_a-init.o] Error 1
       > make[2]: Leaving directory '/private/tmp/nix-build-bitcoind-26.0.drv-0/bitcoin-26.0/src'
       > make[1]: *** [Makefile:20138: all-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-bitcoind-26.0.drv-0/bitcoin-26.0/src'
       > make: *** [Makefile:814: all-recursive] Error 1
       For full logs, run 'nix log /nix/store/0f3p440vzing4xpdf9j37kq34z110hjz-bitcoind-26.0.drv'.
error: 1 dependencies of derivation '/nix/store/jxi7hv8zmmnb2bcpsa9vz5cg8a5vq051-nix-shell-env.drv' failed to build

okjodom commented 6 months ago

what is broken on the current flake?

justinmoon commented 6 months ago

Doesn't build on MacOS. Sorry I didn't fill out the description better. Late night debugging in discord. https://discord.com/channels/990354215060795454/1096102512169328753/1207888989105684500

justinmoon commented 6 months ago

I believe this depends on https://github.com/fedimint/fedimint/pull/4349

Kodylow commented 6 months ago

closing this for working https://github.com/fedimint/ui/pull/381

justinmoon commented 6 months ago

closing this for working https://github.com/fedimint/ui/pull/381

I think this PR should be closed, but to be clear https://github.com/fedimint/ui/pull/381 fixes master and this PR fixes releases/v0.2 so we still need to fix releases/v0.2.

Kodylow commented 6 months ago

should we use that same working commit or a different one? and do we actually need to fix it on the release, it's just a dev env issue?

justinmoon commented 6 months ago

We don't need to fix v0.2 if you we won't need to change it at all. Perhaps it's good enough as-is. It seemed like you wanted to change something on v0.2 but maybe I was mistaken.

Kodylow commented 6 months ago

no just needed to change to to get the dev environment working

fedimint / ui

feat: fix nix flake #377