fedimint / ui

https://ui-umber-ten.vercel.app
MIT License
26 stars 39 forks source link

fix: finality_delay = block_confs - 1 #380

Closed Kodylow closed 6 months ago

Kodylow commented 6 months ago

fixes: https://github.com/fedimint/ui/issues/379

justinmoon commented 6 months ago

What happens if a user enters 0 into the "block confirmations" field?

Kodylow commented 6 months ago

there's a min check in the form element:

<NumberFormControl
                labelText={t('set-config.block-confirmations')}
                helperText={t('set-config.block-confirmations-help')}
                warningText={t('set-config.block-confirmations-warning')}
                recommendedMin={6}
                min={1}
                max={200}
                value={blockConfirmations}
                onChange={(value) => {
                  setBlockConfirmations(value);
                }}
              />
Kodylow commented 6 months ago
image