fedimint / ui

https://ui-umber-ten.vercel.app
MIT License
27 stars 41 forks source link

feat: define logic to autogenerate guardian password #394

Closed isaacknjama closed 6 months ago

isaacknjama commented 7 months ago

Addresses #393

This logic generates a 16-character password that guardians can copy and backup and present during password check.

Question: At what point should password check happen?

Updated user flow: image

Screencast from 02-04-2024 10:41:39 ASUBUHI.webm

Kodylow commented 6 months ago

We should also add an acknowledgement checkbox that the user has copied down the secure password

isaacknjama commented 6 months ago

We should also add an acknowledgement checkbox that the user has copied down the secure password

Updated the PR description with screenshot and short video of UI with most recent changes.

The idea is to not allow a guardian to proceed with federation configuration until they acknowledge that the password has been copied and securely backed up.

isaacknjama commented 6 months ago

My observation is that the password is the same in a session for all guardians (leader, follower, and solo) during the Federation details phase of setup.

Would it be necessary to refresh the password after a certain amount of time (e.g. 10 / 20 seconds)?

Kodylow commented 6 months ago

My observation is that the password is the same in a session for all guardians (leader, follower, and solo) during the Federation details phase of setup.

What do you mean here? the password is supposed to be the same on the same fedimint guardian instance regardless of what role they choose in the setup ceremony?

isaacknjama commented 6 months ago

My observation is that the password is the same in a session for all guardians (leader, follower, and solo) during the Federation details phase of setup.

What do you mean here? the password is supposed to be the same on the same fedimint guardian instance regardless of what role they choose in the setup ceremony?

Makes sense. It's just a concern I had, thought I should mention it.