search

fedimint / ui

MIT License
23 stars 35 forks source link

feat: invite code in guardian auth #431

Closed Kodylow closed 2 weeks ago

Kodylow commented 1 month ago

Was working on this today and not putting the inviteCode in the auth means you have to separately connect as a client then auth as a guardian.

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The recent changes refactor the `DangerZone` and related components within the `guardian-ui` application. The primary adjustment is the replacement of the `config` prop with an `inviteCode` prop, along with related logic updates. This affects the `FederationAdmin`, `DangerZone`, and `GuardianAuthenticationCode` components, ensuring a more streamlined and coherent way of managing invite-related functionality across the application. ## Changes | File Path | Summary of Changes | |--------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------| | `apps/guardian-ui/src/admin/FederationAdmin.tsx` | Updated `DangerZone` component call to include an `inviteCode` prop instead of `config`. | | `apps/guardian-ui/src/components/DangerZone.tsx` | Modified `DangerZone` to accept `inviteCode` prop, updating prop types and logic. | | `apps/guardian-ui/src/components/dashboard/danger/...` | Updated `GuardianAuthenticationCode` component to use `inviteCode` and refactored the authentication code logic. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 482ea3d17da828cb517717e96b3295e79b46ded2 and 0e38412ed063d69c438163488ef77848414fa5c8.
Files ignored due to path filters (2) * `apps/guardian-ui/src/assets/svgs/chevron-down.svg` is excluded by `!**/*.svg` * `apps/guardian-ui/src/assets/svgs/chevron-up.svg` is excluded by `!**/*.svg`
Files selected for processing (1) * apps/guardian-ui/src/components/dashboard/danger/DangerZone.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1) * apps/guardian-ui/src/components/dashboard/danger/DangerZone.tsx
--- > [!TIP] >
> Early access features: disabled > > We are currently testing the following features in early access: > > - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. > > Note: > - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. > - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. > - OSS projects are currently opted into early access features by default. > >
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.