search

fedimint / ui

MIT License
23 stars 35 forks source link

feat: confirm leader done modal #434

Closed Kodylow closed 3 weeks ago

Kodylow commented 1 month ago

Adds a modal for the leader to confirm the followers are done and connected before continuing past "verify guardians", if the setup leader goes first the other followers can't call "start consensus".

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@Kodylow has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 11 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 75e73b679cfabdc7cbba424305a0d03bcf102dd2 and 6b8fcf4d0c528e695c5076f5091fa0bea83cf6e2.

Walkthrough

The updates introduce a modal for leader confirmation in the VerifyGuardians component, add conditional rendering for role-specific messages in SetupComplete, and update the en.json language file with new strings for leader confirmation. These changes primarily enhance the user interface and interaction flow when setting up and verifying guardians.

Changes

Files Change Summary
VerifyGuardians.tsx Introduced leader confirmation modal using Chakra UI components; enhanced state management for user interactions.
setup/VerifyGuardians.tsx Added leader confirmation modal; updated state hooks and useCallback dependencies for role-based interactions.
setup/SetupComplete.tsx Added role prop to conditionally render leader or follower completion messages.
languages/en.json Added new strings for leader confirmation UI and follower messages.
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
elsirion commented 1 month ago

Should this even be solved in the UI or should we fool-proof it on the server side? We can merge this PR as a quick fix, but eventually the coordination should be automated if possible.

Kodylow commented 1 month ago

Would much prefer it to be done server side, it's always been kinda finnicky though, there's logic that should be stopping it already but adding this backstop since people keep borking their federation setups by okaying the leader first.

Kodylow commented 3 weeks ago

nits addressed