search

fediverse-devnet / feditest-tests-fediverse

The tests for the fediverse testsuite
MIT License
5 stars 4 forks source link

Fix account identifier in nodes files #103

Closed jernst closed 2 weeks ago

jernst commented 2 weeks ago

The checked-in constellation files are generated from the nodes files, so that's where the account identifier needs to be defined, see also #102.

steve-bate commented 2 weeks ago

Sorry about that. It's confusing to me sometimes because the generated files are being version-controlled.

jernst commented 2 weeks ago

I don't like it either, but I can't think of a better idea if we want to make onboarding as easy as possible.

steve-bate commented 2 weeks ago

Are you planning for devs to use the Makefile.run to run the tests? If so, it could automatically generate the test plan needed for a given Makefile target (e.g., webfinger-all) the first time the test is run. At that point, the test plan is effectively cached, so the next test run wouldn't need to generate it. Ideally, the DX wouldn't be any different than now except that the first test run would be a little slower. It's an improvement to DX in that a dev doesn't need to know about both Makefile.generate and Makefile.run.

The Makefile could also detect changes to node definitions (which would be version-controlled since they aren't generated) and regenerate the test plan automatically when the tests are run after the changes.