search

fedora-ci / jenkins-pipeline-library

Jenkins Pipeline Library for Fedora CI
MIT License
5 stars 5 forks source link

Generate pipeline id from artifactId + testcase name #20

Closed msrb closed 3 years ago

msrb commented 3 years ago

Generating pipeline id from env+params can cause issues when 2 different jobs are reporting on the same test run.

msrb commented 3 years ago

@bgoncalv please take a look.

You can test your use case like this: https://github.com/fedora-ci/rpminspect-pipeline/pull/10/files

Here's my test attempt: https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/PR-10/4/console

bgoncalv commented 3 years ago

lgtm, bigger change than I expected when I reported the issue :)

msrb commented 3 years ago

lgtm, bigger change than I expected when I reported the issue :)

Yeah, there same code was copied for all supported message types. So I squeezed some refactoring in as well :P