fedora-ci / jenkins-pipeline-library

Jenkins Pipeline Library for Fedora CI
MIT License
5 stars 5 forks source link

repoHasTests() step is doing too much #65

Open msrb opened 2 years ago

msrb commented 2 years ago

What started as a relatively simple step (repoHasTests()) turned into a quite complicated thing that is trying to do way too much. The behavior of the step is not even fully documented -- but this is on purpose, i.e. we don't want to fix the docs.

It would be better to split the functionality into 2 or 3 separate steps:

  1. clone step
  2. extract information step(s)

This way we could clone the repository and then run any number of steps that would extract all the info we need. Currently one of the hidden (undocumented) features of the step is that it also reads ci.fmf file and checks if a specific configuration option is there (resultsdb-testcase).