search

fedora-ci / mini-tps

Installability test for RPMs
GNU General Public License v2.0
1 stars 8 forks source link

consistently call plain `repoquery`, ensure it is available (#47) #48

Closed AdamWill closed 6 months ago

AdamWill commented 6 months ago

https://github.com/fedora-ci/mini-tps/pull/45 changed two of the three places we try and do a repoquery operation from calling "$YUMDNFCMD" repoquery to just calling repoquery, but it missed one. This fixes the remaining one. Also, this attempts to ensure the plain repoquery command will always be available. It's not safe to assume this, because it's part of dnf-utils (on Fedora) and yum-utils (on EL), it's not part of core dnf/yum, and nothing much else requires it. It does seem to be missing in the environment in which tests on Fedora package pull requests run, for instance, which caused the test to fail on all pull requests until the build with #45 was temporarily removed.

AdamWill commented 6 months ago

This is an alternative to #49 , it only makes sense to merge one or the other (or neither!) but not both.

msrb commented 6 months ago

Thanks! I like the simplicity of this fix :+1:

msrb commented 6 months ago

@jpopelka WDYT?

jpopelka commented 6 months ago

Thank you!